Matthias Clasen [Sat, 28 Jun 2014 20:22:43 +0000 (16:22 -0400)]
widget-factory: Small cleanup
Use gtk_builder_new_from_resource and get rid of an unneeded GError.
Matthias Clasen [Sat, 28 Jun 2014 20:19:33 +0000 (16:19 -0400)]
widget-factory: Make the entry progress stop as well
Matthias Clasen [Sat, 28 Jun 2014 19:51:33 +0000 (15:51 -0400)]
GtkEntry: Make progress pulsing smooth
This changes the calculation of activity mode progress in the
same way as was done in GtkProgressBar a while ago, and make it
smooth, using a tick callback.
Matthias Clasen [Sat, 28 Jun 2014 19:23:29 +0000 (15:23 -0400)]
widget-factory: Make the entry progress variable too
Make the scale that currently controls the speed of the progressbar
control the progress speed in the entry as well.
Stefan Sauer [Sun, 25 May 2014 19:35:14 +0000 (21:35 +0200)]
scrolledwindow: fix scrolling with shared adjustment
The GtkPolicyType set on the scrollbar is just about the presentation. What
matters for scrolling is the adjustment.
https://bugzilla.gnome.org/show_bug.cgi?id=730730
Matthias Clasen [Sat, 28 Jun 2014 15:37:29 +0000 (11:37 -0400)]
widget-factory: Add an icon view
We didn't have one before, and this gives us a chance to show off
rubberbanding and symbolic icon rendering.
Matthias Clasen [Sat, 28 Jun 2014 15:13:17 +0000 (11:13 -0400)]
Disable deprecation warnings for installed reftests
Otherwise, these fail in continuous.
Matthias Clasen [Sat, 28 Jun 2014 15:12:23 +0000 (11:12 -0400)]
widget-factory: Enable alpha in the color button
This lets us verify that the theme treats the alpha scale fairly.
Matthias Clasen [Sat, 28 Jun 2014 14:59:41 +0000 (10:59 -0400)]
notification test: Always disable runtime deprecation warnings
These are just not useful in a test that generically deals with
all properties.
Matthias Clasen [Sat, 28 Jun 2014 14:58:24 +0000 (10:58 -0400)]
Exclude GtkToggleButton::draw-indicator from the notification test
We reverted to emitting redundant notifications for this, so
don't assert that we don't.
Matthias Clasen [Sat, 28 Jun 2014 14:56:54 +0000 (10:56 -0400)]
GtkButton: warn slightly less
Use gtk_misc_set_alignment when setting x/align on button children
where possible, to avoid the runtime warning that g_object_set
incurs nowadays.
Lapo Calamandrei [Sat, 28 Jun 2014 13:22:23 +0000 (15:22 +0200)]
Adwaita: minor code refactoring
Lapo Calamandrei [Sat, 28 Jun 2014 13:05:06 +0000 (15:05 +0200)]
Adwaita: button work
- finally fixed +|- buttons on inline toolbars
- commented out :focus and :selected for normal buttons since it makes
flat buttons background blue...
Bastien Nocera [Fri, 27 Jun 2014 10:52:34 +0000 (12:52 +0200)]
docs: Sort GDK_DEBUG values alphabetically
https://bugzilla.gnome.org/show_bug.cgi?id=732330
Bastien Nocera [Fri, 27 Jun 2014 10:46:34 +0000 (12:46 +0200)]
docs: Sort GDK_DEBUG values alphabetically
https://bugzilla.gnome.org/show_bug.cgi?id=732330
Matthias Clasen [Sat, 28 Jun 2014 05:51:24 +0000 (01:51 -0400)]
Avoid a redundant strlen
The GString knows perfectly well how long it is. Pointed out in
https://bugzilla.gnome.org/show_bug.cgi?id=731158
Matthias Clasen [Sat, 28 Jun 2014 05:34:25 +0000 (01:34 -0400)]
Adwaita: Neuter frames in statusbars
Too much.
Matthias Clasen [Sat, 28 Jun 2014 04:41:26 +0000 (00:41 -0400)]
Fight deprecation warnings in test
This time, in installed tests.
Saurabh [Fri, 27 Jun 2014 16:41:09 +0000 (22:11 +0530)]
Adding 'no-matches' signal support to gtkentrycompletion
Add a new 'no-matches' signal and add a function pointer to gtkentrycompletionclass
and remove one from the padding at the end.
https://bugzilla.gnome.org/show_bug.cgi?id=726566
William Jon McCann [Fri, 18 Jan 2013 21:50:47 +0000 (16:50 -0500)]
Allow activating an item after single click on a different item
We were ignoring double click events when a different item was
previously selected.
https://bugzilla.gnome.org/show_bug.cgi?id=484640
Matthias Clasen [Sat, 28 Jun 2014 04:20:19 +0000 (00:20 -0400)]
GtkPrintUnixDialog: Set a higher limit for the number of copies
As requested in bug 672676.
Emilio Pozuelo Monfort [Mon, 23 Jun 2014 16:21:08 +0000 (18:21 +0200)]
wayland: don't change the cursor if there is no pointer
https://bugzilla.gnome.org/show_bug.cgi?id=732206
Jasper St. Pierre [Thu, 26 Jun 2014 18:16:26 +0000 (14:16 -0400)]
colorplane: Don't connect to the configure-event signal
We want to stop people from using configure events
entirely. GtkDrawingArea synthesizes a configure event, but we can just
make the only user of this functionality stop it, and correct the
documentation to not mention it.
Matthias Clasen [Sat, 28 Jun 2014 04:00:16 +0000 (00:00 -0400)]
Improve popover menu spacing
Make iconic buttons have a more reasonable height, and add some
space above an iconic row.
https://bugzilla.gnome.org/show_bug.cgi?id=732229
Matthias Clasen [Sat, 28 Jun 2014 03:53:03 +0000 (23:53 -0400)]
Fix a documentation copy-paste error
The color chooser doesn't deal with fonts.
Matthias Clasen [Sat, 28 Jun 2014 02:03:11 +0000 (22:03 -0400)]
Revert "colorplane: Don't connect to the configure-event signal"
This reverts commit
886f58e1cf2b4918ae33dc2b6279fd7e61c56827.
This made the color plane go missing.
Matthias Clasen [Sat, 28 Jun 2014 01:57:25 +0000 (21:57 -0400)]
GtkMessageDialog: Don't set x/yalign explicitly
The h/valign work fine to give us what we need here, so we
can avoid the runtime deprecation warnings for deprecated
properties.
Matthias Clasen [Sat, 28 Jun 2014 01:44:40 +0000 (21:44 -0400)]
widget-factory: Stop using GtkImageMenuItem
A plain GtkMenuItem works just fine here.
Matthias Clasen [Sat, 28 Jun 2014 01:43:04 +0000 (21:43 -0400)]
widget-factory: Stop using the deprecated GtkAlignment::left-padding
These alignments can just be dropped without loss.
Matthias Clasen [Sat, 28 Jun 2014 01:40:50 +0000 (21:40 -0400)]
widget-factory: Don't use deprecated GtkColorButton::color
Instead, simply set the rgba property, which accepts the
same value.
Matthias Clasen [Sat, 28 Jun 2014 01:35:49 +0000 (21:35 -0400)]
widget-factory: Drop redundant defaults from the .ui file
In particular, we drop xalign, since it is deprecated.
Matthias Clasen [Sat, 28 Jun 2014 01:29:18 +0000 (21:29 -0400)]
GtkSettings: defensive defaults
Change the default value of the gtk-decoration-layout setting
to menu:minimize,maximize,close. The masses want it that way.
Matthias Clasen [Sat, 28 Jun 2014 01:22:40 +0000 (21:22 -0400)]
Bring back redundant notifications for GtkToggleButton::draw-indicator
GtkCheckButton sets a different initial value for this property without
actually changing the declared default, and then relies on change notification
to update other properties (such as xalign). This, combined with glades
insistance on putting default values into ui files creates a situation
where we can't remove the redundant notification for ::draw-indicator
without causing lots of checkboxes to suddenly have centered labels.
This was seen in gnome-terminal, evolution, and other applications.
Therefore, keep the extra notification for now. This can be revisited
when we clean up the button hierarchy.
Matthias Clasen [Fri, 27 Jun 2014 22:43:59 +0000 (18:43 -0400)]
inspector: Chain up in constructed
Its the right thing to do.
Lapo Calamandrei [Fri, 27 Jun 2014 14:23:12 +0000 (16:23 +0200)]
Adwaita: export the right color for the wm hilight dark var
Jasper St. Pierre [Thu, 26 Jun 2014 23:47:39 +0000 (19:47 -0400)]
gtkwindow: Refactor out some similar code for grips
Jasper St. Pierre [Thu, 26 Jun 2014 23:45:55 +0000 (19:45 -0400)]
gtkwindow: Merge some similar code
Jasper St. Pierre [Thu, 26 Jun 2014 23:43:28 +0000 (19:43 -0400)]
gtkwindow: Remove a dead chain-up
GtkWidget / GtkBin don't have configure-event handlers, so we don't need
to attempt to chain up to them.
Lapo Calamandrei [Fri, 27 Jun 2014 12:53:31 +0000 (14:53 +0200)]
Adwaita: remove borders from flat frames
Lapo Calamandrei [Fri, 27 Jun 2014 12:47:29 +0000 (14:47 +0200)]
Adwaita: remove borders from scrollbars junction
Lapo Calamandrei [Fri, 27 Jun 2014 12:24:53 +0000 (14:24 +0200)]
Adwaita: initial flat entry styling.
Lapo Calamandrei [Fri, 27 Jun 2014 11:15:54 +0000 (13:15 +0200)]
Adwaita: .flat button styling
Matthias Clasen [Thu, 26 Jun 2014 03:17:26 +0000 (23:17 -0400)]
GtkFrame: Use style classes for shadow
Use the FLAT style class when shadow is set to none, and
let the theme render the appropriate border.
https://bugzilla.gnome.org/show_bug.cgi?id=732256
Matthias Clasen [Thu, 26 Jun 2014 02:08:27 +0000 (22:08 -0400)]
GtkEntry: Make has-frame use style classes
Instead of code that internally does weird things, use the FLAT style
class if has-frame is FALSE and remove it otherwise.
Based on a patch by Benjamin Otte.
https://bugzilla.gnome.org/show_bug.cgi?id=732256
fixup entry
Matthias Clasen [Fri, 27 Jun 2014 01:59:06 +0000 (21:59 -0400)]
GtkButton: Use FLAT style class
This commit makes button always draw background and frame.
Buttons with relief none get a new style class, FLAT, which
allows themes to style these buttons as they like.
We also (finally) mark GTK_RELIEF_HALF as deprecated. It
has never done anything different from GTK_RELIEF_NORMAL.
https://bugzilla.gnome.org/show_bug.cgi?id=732256
Matthias Clasen [Fri, 27 Jun 2014 02:00:29 +0000 (22:00 -0400)]
Add a FLAT style class
This will be used for frame-less buttons and frames in the future.
Matthias Clasen [Thu, 26 Jun 2014 03:43:35 +0000 (23:43 -0400)]
GtkScrolledWindow: Use style classes for shadow
Translate shadow != None into the FRAME style class.
This doesn't change the style classes used for drawing,
it only sets the style class permanently instead of
saving and restoring in draw().
https://bugzilla.gnome.org/show_bug.cgi?id=732256
Matthias Clasen [Thu, 26 Jun 2014 03:42:47 +0000 (23:42 -0400)]
GtkViewport: Use style classes for shadow
Translate shadow != None into the FRAME style class.
This doesn't change the style classes used for drawing,
it only sets the style class permanently instead of
saving and restoring in draw().
https://bugzilla.gnome.org/show_bug.cgi?id=732256
Jasper St. Pierre [Thu, 26 Jun 2014 22:22:42 +0000 (18:22 -0400)]
gtk: Don't use GObjectClass.constructor
Use the newer constructed instead, which has a fast path in GObject.
Matthias Clasen [Thu, 26 Jun 2014 21:58:43 +0000 (17:58 -0400)]
Flip GTK_STOCK_CLEAR icon in rtl locales
Adwaita now includes an edit-clear-rtl variant, so lets use it.
Jasper St. Pierre [Thu, 26 Jun 2014 19:05:41 +0000 (15:05 -0400)]
gtkwindow: Remove a dumb invalidate_rect from our configure_event
We shouldn't invalidate the entire window when we receive a
ConfigureNotify. That's just broken.
Jasper St. Pierre [Thu, 26 Jun 2014 19:00:59 +0000 (15:00 -0400)]
gtkwindow: Remove a vestigal line of painting for OR windows
Since we have a paint clock, we shouldn't be sending out EXPOSE events
for OR windows inside the ALLOCATE cycle. The idea here was that we
would have to wait for a map to get an OR window to paint to, but since
then this has been abstracted away inside GDK and the paint clock.
Jasper St. Pierre [Thu, 26 Jun 2014 18:41:02 +0000 (14:41 -0400)]
gtkwindow: Remove an unnecessary set of grip setting
We already update the grip position in _gtk_window_set_allocation, which
is done through the size_allocate above. Receiving a ConfigureNotify
also won't ever change a grip's visibility, so there's no point in
refreshing it.
Jasper St. Pierre [Thu, 26 Jun 2014 18:17:56 +0000 (14:17 -0400)]
treeview: Remove configure-event handler as well
Jasper St. Pierre [Thu, 26 Jun 2014 18:16:26 +0000 (14:16 -0400)]
colorplane: Don't connect to the configure-event signal
We want to stop people from using configure events
entirely. GtkDrawingArea synthesizes a configure event, but we can just
make the only user of this functionality stop it, and correct the
documentation to not mention it.
Emmanuele Bassi [Thu, 26 Jun 2014 18:23:52 +0000 (19:23 +0100)]
docs: Show examples of how to use templates API
The template documentation is lacking inlined examples on how to use the
templates API, like binding children and callbacks. This makes looking
for best practices a bit harder than it ought to be, for a feature this
useful.
Jasper St. Pierre [Thu, 26 Jun 2014 14:30:29 +0000 (10:30 -0400)]
gtkwindow: Force CSD on Wayland
We rely on CSD here on the Wayland platform and giving the opportunity
to turn it off doesn't make too much sense.
Rico Tzschichholz [Thu, 26 Jun 2014 12:04:42 +0000 (14:04 +0200)]
icon-browser: Add iconbrowser.gresource.xml to EXTRA_DIST
Matthias Clasen [Wed, 25 Jun 2014 20:23:57 +0000 (16:23 -0400)]
Disable deprecation warnings in tests
We want to test deprecated properties, so failing the tests with
warnings is not productive.
Piotr Drąg [Wed, 25 Jun 2014 18:05:56 +0000 (20:05 +0200)]
Updated POTFILES.skip
Matthias Clasen [Wed, 25 Jun 2014 17:52:18 +0000 (13:52 -0400)]
icon-theme: Add another lookup order test
This tests rtl lookup order for non-symbolic icons.
Matthias Clasen [Wed, 25 Jun 2014 16:36:20 +0000 (12:36 -0400)]
icon-browser: drop icons that were removed from Adwaita
These non-standard icons were dropped from Adwaita. Eventually,
the icon-browser code should be changed to show all standard
icons + whatever is actually in the icon theme, instead of
hardcoding a list of non-standard names.
Carlos Garnacho [Tue, 24 Jun 2014 17:08:51 +0000 (19:08 +0200)]
gesture: Consume the event triggering ::begin if reset within the handler
If the event triggers GtkGesture::begin, and the handler ends up resetting
the gesture (say, due to taking a grab somewhere else within the handler),
still take the event as "managed", as it actually triggered recognition,
even if just to end abruptly.
https://bugzilla.gnome.org/show_bug.cgi?id=731711
Matthias Clasen [Wed, 25 Jun 2014 10:50:39 +0000 (06:50 -0400)]
icon-browser: fix a typo
Matthias Clasen [Wed, 25 Jun 2014 02:24:46 +0000 (22:24 -0400)]
icon browser: drop an misnamed icon
small-progress was just my local test icon for scaling of spinners.
Matthias Clasen [Tue, 24 Jun 2014 22:36:29 +0000 (18:36 -0400)]
Add an icon browser
This is meant to help app authors choose the right icons.
Richard Hughes [Tue, 24 Jun 2014 20:17:39 +0000 (21:17 +0100)]
Makefile: Actually dist the high-contrast and dark test files
Lapo Calamandrei [Tue, 24 Jun 2014 18:17:38 +0000 (20:17 +0200)]
Adwaita: add inconsistent hover check/radios
Matthias Clasen [Tue, 24 Jun 2014 17:30:33 +0000 (13:30 -0400)]
Another forgotten file
Matthias Clasen [Tue, 24 Jun 2014 17:23:29 +0000 (13:23 -0400)]
Forgotten file
Matthias Clasen [Tue, 24 Jun 2014 17:21:05 +0000 (13:21 -0400)]
GtkButton: Queue a redraw on enter/leave
We currently getting a redraw for buttons, but that is just luck.
Better to make it explicit.
Matthias Clasen [Tue, 24 Jun 2014 17:12:56 +0000 (13:12 -0400)]
Drop standalone pixbuf-demo
The same demo is included in gtk3-demo. One copy is enough.
Matthias Clasen [Tue, 24 Jun 2014 17:03:47 +0000 (13:03 -0400)]
GtkToggleButton: Queue a redraw on enter/leave
Without this, we don't redraw consistently for prelight state changes.
Matthias Clasen [Tue, 24 Jun 2014 15:45:57 +0000 (11:45 -0400)]
Bump version
Matthias Clasen [Tue, 24 Jun 2014 11:54:10 +0000 (07:54 -0400)]
3.13.3
Matthias Clasen [Tue, 24 Jun 2014 12:21:29 +0000 (08:21 -0400)]
Avoid deprecation warnings
We know regions are deprecated, no need to warn about it here.
Lapo Calamandrei [Tue, 24 Jun 2014 12:04:26 +0000 (14:04 +0200)]
Adwaita: set the correct indicator color for reorderable hover tabs
Lapo Calamandrei [Tue, 24 Jun 2014 11:42:13 +0000 (13:42 +0200)]
Adwaita: only side borders for reorderable tabs
Adam Dingle [Tue, 24 Jun 2014 10:48:47 +0000 (06:48 -0400)]
Require GLib 2.41.1 (for G_PARAM_EXPLICIT_NOTIFY)
Lapo Calamandrei [Tue, 24 Jun 2014 08:38:03 +0000 (10:38 +0200)]
Adwaita: added active state to the switch slider
Lapo Calamandrei [Tue, 24 Jun 2014 08:28:19 +0000 (10:28 +0200)]
Adwaita: comment out button separators removal
...after reading #gnome-design scrollbark, since a consensus on how to achieve
this has not been reached yet.
Lapo Calamandrei [Tue, 24 Jun 2014 08:25:49 +0000 (10:25 +0200)]
Adwaita: fix view check/radio selected state.
Lapo Calamandrei [Tue, 24 Jun 2014 07:28:29 +0000 (09:28 +0200)]
Adwaita: disable separators in buttons
Colomban Wendling [Tue, 24 Jun 2014 01:37:59 +0000 (03:37 +0200)]
gdkwindow: Don't leak the surface in gdk_cairo_create()
Matthias Clasen [Tue, 24 Jun 2014 01:24:41 +0000 (21:24 -0400)]
Add a test for async icon loading
Jasper St. Pierre [Mon, 23 Jun 2014 21:55:55 +0000 (17:55 -0400)]
gtkmain: Rearrange code
Prevent a segfault in unknown circumstances, and break the ignore
deprecations wrapper out from the if statement so that we don't
cover too much ground by accident.
Jasper St. Pierre [Mon, 23 Jun 2014 21:36:43 +0000 (17:36 -0400)]
gtkwidget: Actually mark set_double_buffered as deprecated
Jasper St. Pierre [Mon, 23 Jun 2014 21:36:16 +0000 (17:36 -0400)]
Revert "gtkwidget: Widgets are now always double-buffered"
This reverts commit
b875572f2af532b0e8f2dc368f8dc824b5f92724.
Apps like Abiword, gnumeric and gnome-chess, and toolkits like
ClutterGTK were all using this for various purposes, and this made them
break. Bring back this feature for now.
It still won't work under Wayland.
Jasper St. Pierre [Mon, 23 Jun 2014 21:33:14 +0000 (17:33 -0400)]
gdkwindow: Allow calling gdk_cairo_create outside of a "paint"
Apps had quite a bit of difficulty getting used to the new rules.
While we weren't expecting anything too deadly, it seemed that
gnumeric and Abiword both used gdk_cairo_create like this.
Jasper St. Pierre [Mon, 23 Jun 2014 20:15:48 +0000 (16:15 -0400)]
gdkwindow: Remove extra arguments from process_updates_recurse_helper
These can easily be calculated inside the function.
Jasper St. Pierre [Mon, 23 Jun 2014 20:12:45 +0000 (16:12 -0400)]
gdkwindow: Don't do some extra work
We can do an early return in some specific cases before we need to
create and clip a cairo region.
Jasper St. Pierre [Mon, 23 Jun 2014 20:11:56 +0000 (16:11 -0400)]
gdkwindow: Remove an unused variable
Jasper St. Pierre [Mon, 23 Jun 2014 16:29:55 +0000 (12:29 -0400)]
gdkwindow: Make the precondition of gdk_window_add_damage clearer
Jasper St. Pierre [Mon, 23 Jun 2014 16:23:48 +0000 (12:23 -0400)]
gdkwindow: Simplify check for damaging offscreen windows
If a window both has an impl and its impl_window is of type offscreen,
that must mean that it is the offscreen window, and the impl window is
itself. We can reduce the indirection here and make it more clear.
Jasper St. Pierre [Mon, 23 Jun 2014 16:22:33 +0000 (12:22 -0400)]
gdkwindow: Make gdk_window_add_damage more private
Matthias Clasen [Mon, 23 Jun 2014 16:20:59 +0000 (12:20 -0400)]
GtkIconTheme: Copy all fields in icon_info_dup
This functionality is only exercised by gnome-shell, currently.
Therefore, forgetting to copy a field here means an instant
gnome-shell crash :-(. More tests needed.
Matthias Clasen [Mon, 23 Jun 2014 16:13:22 +0000 (12:13 -0400)]
GtkIconTheme: Be more careful when warning
It sucks when printing a warning causes gnome-shell to crash,
so be more careful about icon names being NULL here.
Matthias Clasen [Mon, 23 Jun 2014 11:05:29 +0000 (07:05 -0400)]
GtkIconTheme: keep misplaced symbolics working
Recent changes made it a breaking mistake to install symbolic icons
of the wrong size into a theme directory, or into the legacy unthemed
icon location.
Since this change affects many apps, do the extra work to keep these
icons working, but emit warnings, in the hope that this will lead to
cleaning up the mess over time.
Matthias Clasen [Mon, 23 Jun 2014 02:04:00 +0000 (22:04 -0400)]
Move some comments around
Matthias Clasen [Sun, 22 Jun 2014 20:46:11 +0000 (16:46 -0400)]
Some documentation rewording